This repository was archived by the owner on Oct 2, 2019. It is now read-only.
Add support to disable search feature. #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about bootstrap theme? Somehow we should try give all themes the same features. BTW, can you add a test to it? |
|
+1 |
|
@dimirc Does this pr look good? |
|
@jverghese looks good but I want to see how we can integrate correctly with other feature request that looks related #113 We could keep diferent parameters one to enable/disable with search-enabled and other for minimum results for search or try to integrate them into one |
|
@dimirc, I think it might be good to have separate parameters, because you may or may not want to use them in conjunction. |
|
@dimirc Thanks. Appreciate a resolution on this. Let me know if I can help. |
dimirc
added a commit
that referenced
this pull request
Aug 29, 2014
Add support to disable search feature.
|
@jverghese thanks and any help commenting on other issues/PR are very welcome |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an option to explicitly disable search - This is useful in scenarios where the option list is small/simple and searching over it would be overkill.
Screenshots: